Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Fix PaymentCardTextField bugs #692

Closed

Conversation

rkrueger11
Copy link

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to tipsi-stripe?
Put an x in the boxes that apply

  • [x ] Bugfix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! Next steps are a reminder of what we are going to look at before merging your code.

  • I have added tests that prove my fix is useful or that my feature works
  • I have added necessary documentation (if appropriate)
  • I know that my PR will be merged only if it has tests and they pass

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you choose the solution you did and what alternatives you considered.

Fixes:

  1. Unintentional autofocusing functionality on Android with the PaymentCardTextField component
  2. Replaces currentlyFocusedField call (currentlyFocusedField is deprecated and will be removed in a future release. #680)

@rkrueger11 rkrueger11 changed the title Fix textfield bugs Fix PaymentCardTextField bugs Oct 16, 2020
@cybergrind cybergrind requested a review from fbartho October 16, 2020 20:19
@cybergrind cybergrind closed this Dec 25, 2020
@pvinis
Copy link

pvinis commented Feb 8, 2021

Why were all these issues marked as wont-fix and closed? Is this lib not maintained anymore? @cybergrind

@aganov
Copy link

aganov commented Feb 13, 2021

@pvinis #708 We have to wait for official RN library from Stripe. Meanwhile you can keep your own fork with critical patches applied.

@Sheharyar566
Copy link

Not sure about that but @cybergrind should at least accept PRs (while setting a disclaimer at Readme that the lib isn't maintained).... Disclaimer is one thing... but please at least accepts PRs, so that we have something to work with while the official library isn't released.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants